Re: [PATCH] change -e and -t behavior

[Lars Clausen <lrclause cs uiuc edu>]

On 18 Sep 2003, mike@flyn.org wrote:
> A little over a week ago I sent a patch to dia-list that modified dia's
> -e and -t behavior.  I think the new behavior is sane and useful (in my
> case for creating thumbnails of diagram files).  I'd really like to hear
> what people think of my solution.  I would like to see dia have the
> ability to convert(from the command line) diagrams and save the output
> using any filename, not just ones ending in .png, etc.

While the idea is sound, I wish you'd at least try to compile the patch
before submitting it.  Here's the output from compiling:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -I/usr/include/libxml2 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/libart-2.0 -DDIA_SHEETDIR=\"/usr/local/share/dia/sheets\" -DLIBDIR=\"/usr/local/lib\" -DDATADIR=\"/usr/local/share/dia\" -I/usr/include/libxml2 -I/usr/include/freetype2 -g -O2 -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -finline-functions -fstrict-aliasing -Wp,-MD,.deps/filter.pp -c filter.c  -fPIC -DPIC -o .libs/filter.o
filter.c:84: warning: no previous prototype for `filter_get_export_filter'
filter.c: In function `filter_get_export_filter':
filter.c:86: warning: declaration of `ext' shadows a parameter
filter.c: In function `filter_guess_export_filter':
filter.c:113: parse error before `}'
filter.c:120: `fa' undeclared (first use in this function)
filter.c:120: (Each undeclared identifier is reported only once
filter.c:120: for each function it appears in.)
filter.c:120: `fb' undeclared (first use in this function)
filter.c:120: warning: return makes pointer from integer without a cast
filter.c:103: warning: unused variable `tmp'
filter.c: In function `filter_register_import':
filter.c:130: `import_filter_compare' undeclared (first use in this function)
filter.c: In function `filter_get_export_filter':
filter.c:86: warning: `ext' might be used uninitialized in this function

Once it compiles, I shall be happy to test it.

-Lars

-- 
Lars Clausen (http://shasta.cs.uiuc.edu/~lrclause)| Hårdgrim of Numenor
"I do not agree with a word that you say, but I   |----------------------------
will defend to the death your right to say it."   | Where are we going, and
    --Evelyn Beatrice Hall paraphrasing Voltaire  | what's with the handbasket?